This repository was archived by the owner on Sep 6, 2021. It is now read-only.
The Hangul(Korean characters) allow in the group-name field. #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@rottmann ping |
|
+1 |
Member
|
Set it on Todo. must check first the usage of names with non alphabetical chars globally. |
|
Russian letters skipped as well. group = group.replace(/[^\w\u0400-\u04FF\u3130-\u318F\uAC00-\uD7AF]/gi, '_');would help. TIA |
Author
|
Good suggestion ! I would like to fix it gracefully. On Wed, Jun 29, 2016 at 18:53 Vladimir Dronnikov notifications@github.com
|
|
|
|
|
|
|
Member
|
Because it is a name (full UTF charset is currently not suppored). Change it here, need to change other places too, e.g. apiDefine, apiUse, .... |
|
@rottmann try |
NicolasCARPi
added a commit
that referenced
this pull request
Oct 16, 2019
Collaborator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
I've just started using apidocjs for my API project and it's awesome open source !
I tried to write Korean characters in the group name field like "@APIGroup 결제".
you know, I'm a Korean(south) but I have a problem using Korean characters.
even if I use the Korean language and confirmed that there is no problem.
Please check this commiting for the Korea people. thanks.